Drawsprites on HUD issue

Hello there, fellow developers! It's been a while, isn't it?

I've been tryin to draw sprites related to player-scoped global variables, but i've been suffering to achieve some progress.

The code i came up with is shown below, but it seems to be useless. It's a "ondrawscript" attached to de player entities, but my line of thought must be terribly wrong.

Code:
void main()
{


void ShardEquippedP1, ShardEquippedP2, ShardIcon0, ShardIcon1, ShardIcon2, ShardIcon3, ShardIcon4, ShardIcon5, ShardIcon6, ShardIcon7, ShardIconP1, ShardIconP2;

if(getglobalvar("ShardIcon0") == NULL())		setglobalvar("ShardIcon0",loadsprite("data/items/shard/pal_00.png"));
if(getglobalvar("ShardIcon1") == NULL())		setglobalvar("ShardIcon1",loadsprite("data/items/shard/pal_01.png"));
if(getglobalvar("ShardIcon2") == NULL())		setglobalvar("ShardIcon2",loadsprite("data/items/shard/pal_02.png"));
if(getglobalvar("ShardIcon3") == NULL())		setglobalvar("ShardIcon3",loadsprite("data/items/shard/pal_03.png"));
if(getglobalvar("ShardIcon4") == NULL())		setglobalvar("ShardIcon4",loadsprite("data/items/shard/pal_04.png"));
if(getglobalvar("ShardIcon5") == NULL())		setglobalvar("ShardIcon5",loadsprite("data/items/shard/pal_05.png"));
if(getglobalvar("ShardIcon6") == NULL())		setglobalvar("ShardIcon6",loadsprite("data/items/shard/pal_06.png"));
if(getglobalvar("ShardIcon7") == NULL())		setglobalvar("ShardIcon7",loadsprite("data/items/shard/pal_07.png"));

if(getglobalvar("ShardEquippedP1")==NULL())		{setglobalvar("ShardEquippedP1",0);}
if(getglobalvar("ShardEquippedP2")==NULL())		{setglobalvar("ShardEquippedP2",0);}

if((getplayerproperty(0,"joining"))==1)
	{
	if(getglobalvar("ShardEquippedP1")==0)			{setglobalvar("ShardIconP1","ShardIcon0");}
	if(getglobalvar("ShardEquippedP1")==1)			{setglobalvar("ShardIconP1","ShardIcon1");}
	if(getglobalvar("ShardEquippedP1")==2)			{setglobalvar("ShardIconP1","ShardIcon2");}
	if(getglobalvar("ShardEquippedP1")==3)			{setglobalvar("ShardIconP1","ShardIcon3");}
	if(getglobalvar("ShardEquippedP1")==4)			{setglobalvar("ShardIconP1","ShardIcon4");}
	if(getglobalvar("ShardEquippedP1")==5)			{setglobalvar("ShardIconP1","ShardIcon5");}
	if(getglobalvar("ShardEquippedP1")==6)			{setglobalvar("ShardIconP1","ShardIcon6");} 
	if(getglobalvar("ShardEquippedP1")==7)			{setglobalvar("ShardIconP1","ShardIcon7");}
	drawsprite(ShardIconP1, 148, 240, 70050, 0);
	//settextobj(0, 20,  20, 1, 999999999, ""+getglobalvar("ShardEquippedP1"));
	}

if((getplayerproperty(1,"joining"))==1)
	{
	if(getglobalvar("ShardEquippedP2")==0)			{setglobalvar("ShardIconP2","ShardIcon0");}
	if(getglobalvar("ShardEquippedP2")==1)			{setglobalvar("ShardIconP2","ShardIcon1");}
	if(getglobalvar("ShardEquippedP2")==2)			{setglobalvar("ShardIconP2","ShardIcon2");}
	if(getglobalvar("ShardEquippedP2")==3)			{setglobalvar("ShardIconP2","ShardIcon3");}
	if(getglobalvar("ShardEquippedP2")==4)			{setglobalvar("ShardIconP2","ShardIcon4");}
	if(getglobalvar("ShardEquippedP2")==5)			{setglobalvar("ShardIconP2","ShardIcon5");}
	if(getglobalvar("ShardEquippedP2")==6)			{setglobalvar("ShardIconP2","ShardIcon6");}
	if(getglobalvar("ShardEquippedP2")==7)			{setglobalvar("ShardIconP2","ShardIcon7");}
	drawsprite(ShardIconP2, 290, 240, 70050, 0);
	//settextobj(1, 20,  30, 1, 999999999, ""+getglobalvar("ShardEquippedP2"));
	}

}
 
Code:
if((getplayerproperty(0,"joining"))==1)

This line could be the reason it is not working maybe try a test where you check if player 1 + 2 have more then 0 HP.

Code:
if( getentityproperty(getplayerproperty(0,"entity"),"health")>0)

or it could be them extra brackets you have !

if((getplayerproperty(0,"joining"))==1)
 
I've updated the code and, even still crashing, now I have some info:

Here's the new code, thanks to Malik:
Code:
void main()
{


void ShardEquippedP1, ShardEquippedP2, ShardIcon0, ShardIcon1, ShardIcon2, ShardIcon3, ShardIcon4, ShardIcon5, ShardIcon6, ShardIcon7, ShardIconP1, ShardIconP2;

if(getglobalvar("ShardIcon0") == NULL())		setglobalvar("ShardIcon0",loadsprite("data/items/shard/pal_00.png"));
if(getglobalvar("ShardIcon1") == NULL())		setglobalvar("ShardIcon1",loadsprite("data/items/shard/pal_01.png"));
if(getglobalvar("ShardIcon2") == NULL())		setglobalvar("ShardIcon2",loadsprite("data/items/shard/pal_02.png"));
if(getglobalvar("ShardIcon3") == NULL())		setglobalvar("ShardIcon3",loadsprite("data/items/shard/pal_03.png"));
if(getglobalvar("ShardIcon4") == NULL())		setglobalvar("ShardIcon4",loadsprite("data/items/shard/pal_04.png"));
if(getglobalvar("ShardIcon5") == NULL())		setglobalvar("ShardIcon5",loadsprite("data/items/shard/pal_05.png"));
if(getglobalvar("ShardIcon6") == NULL())		setglobalvar("ShardIcon6",loadsprite("data/items/shard/pal_06.png"));
if(getglobalvar("ShardIcon7") == NULL())		setglobalvar("ShardIcon7",loadsprite("data/items/shard/pal_07.png"));

if(getglobalvar("ShardEquippedP1")==NULL())		{setglobalvar("ShardEquippedP1",0);}
if(getglobalvar("ShardEquippedP2")==NULL())		{setglobalvar("ShardEquippedP2",0);}

// if(getplayerproperty(0,"joining")==1)
if(getentityproperty(getplayerproperty(0,"entity"),"health")>0)
	{
	if(getglobalvar("ShardEquippedP1")==0)			{setglobalvar("ShardIconP1",ShardIcon0);}
	if(getglobalvar("ShardEquippedP1")==1)			{setglobalvar("ShardIconP1",ShardIcon1);}
	if(getglobalvar("ShardEquippedP1")==2)			{setglobalvar("ShardIconP1",ShardIcon2);}
	if(getglobalvar("ShardEquippedP1")==3)			{setglobalvar("ShardIconP1",ShardIcon3);}
	if(getglobalvar("ShardEquippedP1")==4)			{setglobalvar("ShardIconP1",ShardIcon4);}
	if(getglobalvar("ShardEquippedP1")==5)			{setglobalvar("ShardIconP1",ShardIcon5);}
	if(getglobalvar("ShardEquippedP1")==6)			{setglobalvar("ShardIconP1",ShardIcon6);} 
	if(getglobalvar("ShardEquippedP1")==7)			{setglobalvar("ShardIconP1",ShardIcon7);}
	drawsprite(ShardIconP1, 148, 240, 70050, 0);
	}

// if(getplayerproperty(1,"joining")==1)
if(getentityproperty(getplayerproperty(1,"entity"),"health")>0)
	{
	if(getglobalvar("ShardEquippedP2")==0)			{setglobalvar("ShardIconP2",ShardIcon0);}
	if(getglobalvar("ShardEquippedP2")==1)			{setglobalvar("ShardIconP2",ShardIcon1);}
	if(getglobalvar("ShardEquippedP2")==2)			{setglobalvar("ShardIconP2",ShardIcon2);}
	if(getglobalvar("ShardEquippedP2")==3)			{setglobalvar("ShardIconP2",ShardIcon3);}
	if(getglobalvar("ShardEquippedP2")==4)			{setglobalvar("ShardIconP2",ShardIcon4);}
	if(getglobalvar("ShardEquippedP2")==5)			{setglobalvar("ShardIconP2",ShardIcon5);}
	if(getglobalvar("ShardEquippedP2")==6)			{setglobalvar("ShardIconP2",ShardIcon6);}
	if(getglobalvar("ShardEquippedP2")==7)			{setglobalvar("ShardIconP2",ShardIcon7);}
	drawsprite(ShardIconP2, 290, 240, 70050, 0);
	}

}

And here's the error message in the Openbor Log:
Code:
Function requires a valid sprite handle 3 integer values, 5th integer value is optional: drawsprite(sprite, int x, int y, int z, int sortid)
Script function 'drawsprite' returned an exception, check the manual for details.
 parameters: <VT_EMPTY>   Unitialized, 148, 240, 70050, 0,  
 
********** An Error Occurred **********
*            Shutting Down            *

I don't understand why the log shows <VT_EMPTY>, cause both the ShardIconP1 and ShardIconP2 variables are both set on the code.

EDIT:
I've noticed these warnings in the log:
Code:
Warning: 8 script variants are not freed, dumping...
openbor_loadsprite
openbor_loadsprite
openbor_loadsprite
openbor_loadsprite
openbor_loadsprite
openbor_loadsprite
openbor_loadsprite
openbor_loadsprite

Could there be any syntax error on the setup of the ShardIcon variables?
 
But that doesn't mean they aren't set to a NULL value (obviously they are, since that's what the error means).  We just need to find where it's happening.

I don't see anything in your code that ensures the variable going into drawsprite has a legit value.

Sprinkle some log() functions to output some of your variables. That should give us a clue.
 
Add a if condition to draw sprite to check if ShardIconP1 is not null and for ShardIconP2 too.

Edit: I declare all global variables oncreate in the updated.c script and I destroy/null them using ondestroy script see my tekken mod for examples.
 
It's finally working!

Instead of retaining my attention on globals, I used some locals, and now it's working!
Here's the updated code:

Code:
void main()
{


void ShardEquippedP1, ShardEquippedP2, ShardIcon0, ShardIcon1, ShardIcon2, ShardIcon3, ShardIcon4, ShardIcon5, ShardIcon6, ShardIcon7, ShardIconP1, ShardIconP2;

if(getglobalvar("ShardIcon0") == NULL())		{setglobalvar("ShardIcon0",loadsprite("data/items/shard/pal_00.png"));}
if(getglobalvar("ShardIcon1") == NULL())		{setglobalvar("ShardIcon1",loadsprite("data/items/shard/pal_01.png"));}
if(getglobalvar("ShardIcon2") == NULL())		{setglobalvar("ShardIcon2",loadsprite("data/items/shard/pal_02.png"));}
if(getglobalvar("ShardIcon3") == NULL())		{setglobalvar("ShardIcon3",loadsprite("data/items/shard/pal_03.png"));}
if(getglobalvar("ShardIcon4") == NULL())		{setglobalvar("ShardIcon4",loadsprite("data/items/shard/pal_04.png"));}
if(getglobalvar("ShardIcon5") == NULL())		{setglobalvar("ShardIcon5",loadsprite("data/items/shard/pal_05.png"));}
if(getglobalvar("ShardIcon6") == NULL())		{setglobalvar("ShardIcon6",loadsprite("data/items/shard/pal_06.png"));}
if(getglobalvar("ShardIcon7") == NULL())		{setglobalvar("ShardIcon7",loadsprite("data/items/shard/pal_07.png"));}

if(getglobalvar("ShardEquippedP1")==NULL())		{setglobalvar("ShardEquippedP1",0);}
if(getglobalvar("ShardEquippedP2")==NULL())		{setglobalvar("ShardEquippedP2",0);}

ShardIcon0 = getglobalvar("ShardIcon0");
ShardIcon1 = getglobalvar("ShardIcon1");
ShardIcon2 = getglobalvar("ShardIcon2");
ShardIcon3 = getglobalvar("ShardIcon3");
ShardIcon4 = getglobalvar("ShardIcon4");
ShardIcon5 = getglobalvar("ShardIcon5");
ShardIcon6 = getglobalvar("ShardIcon6");
ShardIcon7 = getglobalvar("ShardIcon7");




if(getentityproperty(getplayerproperty(0,"entity"),"health")>0)
	{
	if(getglobalvar("ShardEquippedP1")==0)			{setglobalvar("ShardIconP1",ShardIcon0);}
	if(getglobalvar("ShardEquippedP1")==1)			{setglobalvar("ShardIconP1",ShardIcon1);}
	if(getglobalvar("ShardEquippedP1")==2)			{setglobalvar("ShardIconP1",ShardIcon2);}
	if(getglobalvar("ShardEquippedP1")==3)			{setglobalvar("ShardIconP1",ShardIcon3);}
	if(getglobalvar("ShardEquippedP1")==4)			{setglobalvar("ShardIconP1",ShardIcon4);}
	if(getglobalvar("ShardEquippedP1")==5)			{setglobalvar("ShardIconP1",ShardIcon5);}
	if(getglobalvar("ShardEquippedP1")==6)			{setglobalvar("ShardIconP1",ShardIcon6);} 
	if(getglobalvar("ShardEquippedP1")==7)			{setglobalvar("ShardIconP1",ShardIcon7);}
	ShardIconP1 = getglobalvar("ShardIconP1");
	drawsprite(ShardIconP1, 148, 240, 70050, 0);
	// settextobj(0, 20,  20, 1, 999999999, ""+getglobalvar("ShardEquippedP1"));
	}

if(getentityproperty(getplayerproperty(1,"entity"),"health")>0)
	{
	if(getglobalvar("ShardEquippedP2")==0)			{setglobalvar("ShardIconP2",ShardIcon0);}
	if(getglobalvar("ShardEquippedP2")==1)			{setglobalvar("ShardIconP2",ShardIcon1);}
	if(getglobalvar("ShardEquippedP2")==2)			{setglobalvar("ShardIconP2",ShardIcon2);}
	if(getglobalvar("ShardEquippedP2")==3)			{setglobalvar("ShardIconP2",ShardIcon3);}
	if(getglobalvar("ShardEquippedP2")==4)			{setglobalvar("ShardIconP2",ShardIcon4);}
	if(getglobalvar("ShardEquippedP2")==5)			{setglobalvar("ShardIconP2",ShardIcon5);}
	if(getglobalvar("ShardEquippedP2")==6)			{setglobalvar("ShardIconP2",ShardIcon6);}
	if(getglobalvar("ShardEquippedP2")==7)			{setglobalvar("ShardIconP2",ShardIcon7);}
	ShardIconP2 = getglobalvar("ShardIconP2");
	drawsprite(ShardIconP2, 290, 240, 70050, 0);
	// settextobj(1, 20,  30, 1, 999999999, ""+getglobalvar("ShardEquippedP2"));
	}

}
 
I see the issue with your original code now.

Code:
drawsprite(ShardIconP1, 148, 240, 70050, 0);

the above code should have been.

drawsprite(getglobalvar("ShardIconP1"), 148, 240, 70050, 0);

All the below local variables are not being used.

Code:
void ShardEquippedP1, ShardEquippedP2, ShardIcon0, ShardIcon1, ShardIcon2, ShardIcon3, ShardIcon4, ShardIcon5, ShardIcon6, ShardIcon7, ShardIconP1, ShardIconP2;
 
Back
Top Bottom